LakshSingla commented on code in PR #14886:
URL: https://github.com/apache/druid/pull/14886#discussion_r1321918111
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -137,6 +139,30 @@ public static DataSourcePlan forDataSource(
} else if (dataSource instanceof LookupDataSource) {
checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
return forLookup((LookupDataSource) dataSource, broadcast);
+ } else if (dataSource instanceof FilteredDataSource) {
+ checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
+ return forFilteredDataSource(
+ queryKit,
+ queryId,
+ queryContext,
+ (FilteredDataSource) dataSource,
+ querySegmentSpec,
+ maxWorkerCount,
+ minStageNumber,
+ broadcast
+ );
+ } else if (dataSource instanceof UnnestDataSource) {
+ checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
Review Comment:
Re-confirm if this check is required here. I think it should be removed
unless UNNEST on a table cannot have a time filter.
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/querykit/DataSourcePlan.java:
##########
@@ -137,6 +139,30 @@ public static DataSourcePlan forDataSource(
} else if (dataSource instanceof LookupDataSource) {
checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
return forLookup((LookupDataSource) dataSource, broadcast);
+ } else if (dataSource instanceof FilteredDataSource) {
+ checkQuerySegmentSpecIsEternity(dataSource, querySegmentSpec);
Review Comment:
See the other comment about the check. Perhaps this should also be removed
since we would plan the base data source, and there would be individual checks
there.
See the plan for broadcast joins - The base data source doesn't enforce the
eternity check, however, it is required on the clauses. I think something of
that sort should be applicable in Filtered and Unnest data sources (please
confirm it though)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
