kfaraz commented on code in PR #14880:
URL: https://github.com/apache/druid/pull/14880#discussion_r1333812662
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/AbstractTask.java:
##########
@@ -216,6 +232,23 @@ public void cleanUp(TaskToolbox toolbox, TaskStatus
taskStatus) throws Exception
}
}
+ @Override
+ public boolean waitForCleanupToFinish()
+ {
+ try {
+ if (cleanupCompletionLatch != null) {
+ // block until the cleanup process completes
+ return cleanupCompletionLatch.await(30, TimeUnit.SECONDS);
Review Comment:
Yes, typically it would be fast, but in case it isn't, I believe it is
better to wait a little longer since this change is going to affect all tasks.
The cleanup seems to submit a couple of actions to the Overlord which could be
slow in getting processed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
