adarshsanjeev commented on code in PR #15024:
URL: https://github.com/apache/druid/pull/15024#discussion_r1343538918
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/input/table/SegmentWithDescriptor.java:
##########
@@ -33,30 +42,35 @@
public class SegmentWithDescriptor
{
private final Supplier<? extends ResourceHolder<Segment>> segmentSupplier;
+ private final LoadedSegmentDataProvider loadedSegmentDataProvider;
private final SegmentDescriptor descriptor;
/**
* Create a new instance.
*
- * @param segmentSupplier supplier of a {@link ResourceHolder} of segment.
The {@link ResourceHolder#close()} logic
- * must include a delegated call to {@link
Segment#close()}.
- * @param descriptor segment descriptor
+ * @param segmentSupplier supplier of a {@link ResourceHolder} of
segment. The {@link ResourceHolder#close()}
+ * logic must include a delegated call to
{@link Segment#close()}.
+ * @param loadedSegmentDataProvider {@link LoadedSegmentDataProvider} which
fetches the corresponding results from a
+ * data server where the segment is loaded.
The call will fetch the
+ * @param descriptor segment descriptor
*/
public SegmentWithDescriptor(
final Supplier<? extends ResourceHolder<Segment>> segmentSupplier,
+ final LoadedSegmentDataProvider loadedSegmentDataProvider,
final SegmentDescriptor descriptor
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
