adarshsanjeev commented on code in PR #15024:
URL: https://github.com/apache/druid/pull/15024#discussion_r1343559533
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1158,14 +1163,42 @@ private QueryKit makeQueryControllerToolKit()
private DataSegmentTimelineView makeDataSegmentTimelineView()
{
+ final boolean isIncludeRealtime =
MultiStageQueryContext.isIncludeRealtime(task.getQuerySpec().getQuery().context());
+
return (dataSource, intervals) -> {
- final Collection<DataSegment> dataSegments =
+ final Iterable<ImmutableSegmentLoadInfo> serverViewSegments;
+
+ // Fetch the realtime segments first, so that we don't miss any segment
if they get handed off between the two calls.
+ if (isIncludeRealtime) {
+ serverViewSegments =
context.coordinatorClient().fetchServerViewSegments(dataSource, intervals);
+ } else {
+ serverViewSegments = ImmutableList.of();
+ }
+
+ final Collection<DataSegment> metadataStoreSegments =
FutureUtils.getUnchecked(context.coordinatorClient().fetchUsedSegments(dataSource,
intervals), true);
- if (dataSegments.isEmpty()) {
+ Set<DataSegment> unifiedSegmentView = new
HashSet<>(metadataStoreSegments);
+ for (ImmutableSegmentLoadInfo segmentLoadInfo : serverViewSegments) {
+ ImmutableSet<DruidServerMetadata> servers =
segmentLoadInfo.getServers();
+ Set<DruidServerMetadata> realtimeServerMetadata = servers.stream()
+
.filter(druidServerMetadata ->
+
ServerType.REALTIME.equals(druidServerMetadata.getType()) ||
+
ServerType.INDEXER_EXECUTOR.equals(druidServerMetadata.getType()))
+
.collect(Collectors.toSet());
+ if (!realtimeServerMetadata.isEmpty()) {
Review Comment:
Added
##########
extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/exec/ControllerImpl.java:
##########
@@ -1158,14 +1163,42 @@ private QueryKit makeQueryControllerToolKit()
private DataSegmentTimelineView makeDataSegmentTimelineView()
{
+ final boolean isIncludeRealtime =
MultiStageQueryContext.isIncludeRealtime(task.getQuerySpec().getQuery().context());
+
return (dataSource, intervals) -> {
- final Collection<DataSegment> dataSegments =
+ final Iterable<ImmutableSegmentLoadInfo> serverViewSegments;
+
+ // Fetch the realtime segments first, so that we don't miss any segment
if they get handed off between the two calls.
+ if (isIncludeRealtime) {
+ serverViewSegments =
context.coordinatorClient().fetchServerViewSegments(dataSource, intervals);
+ } else {
+ serverViewSegments = ImmutableList.of();
+ }
+
+ final Collection<DataSegment> metadataStoreSegments =
Review Comment:
Changed
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
