clintropolis commented on code in PR #15127:
URL: https://github.com/apache/druid/pull/15127#discussion_r1357671959
##########
processing/src/test/java/org/apache/druid/segment/transform/TransformerTest.java:
##########
@@ -385,7 +389,7 @@ public void testTransformWithArrayLongInputs()
Assert.assertNotNull(actual);
Assert.assertEquals(ImmutableList.of("dim"), actual.getDimensions());
Assert.assertArrayEquals(new Object[]{1L, 2L, null, 3L}, (Object[])
actual.getRaw("dim"));
- Assert.assertEquals(Arrays.asList("1", "2", "null", "3"),
actual.getDimension("dim"));
+ Assert.assertArrayEquals(new String[]{"1", "2", null, "3"},
actual.getDimension("dim").toArray());
Review Comment:
nit: any reason to convert to array? I think `Arrays.asList` works with
nulls, it was probably a bug earlier that this was being converting `null` to
`"null"`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
