clintropolis commented on code in PR #15127:
URL: https://github.com/apache/druid/pull/15127#discussion_r1358787266
##########
processing/src/main/java/org/apache/druid/segment/transform/ExpressionTransform.java:
##########
@@ -111,9 +110,7 @@ public Object eval(final Row row)
public List<String> evalDimension(Row row)
{
try {
- return Rows.objectToStrings(
Review Comment:
yea, this change is ok in this case because `Rows.objectToStrings` is
translating anything into `List<String>`, this method was just previously
re-using the method used by the expression dimension selector on the query side
to which itself matches
https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/segment/DimensionSelector.java#L141,
but since in this transform it was wrapped in Rows.objectToStrings, that part
of the behavior wasn't important, just the converting an array to a list of
strings part.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
