pranavbhole commented on code in PR #15127:
URL: https://github.com/apache/druid/pull/15127#discussion_r1357690429
##########
processing/src/test/java/org/apache/druid/segment/transform/TransformerTest.java:
##########
@@ -385,7 +389,7 @@ public void testTransformWithArrayLongInputs()
Assert.assertNotNull(actual);
Assert.assertEquals(ImmutableList.of("dim"), actual.getDimensions());
Assert.assertArrayEquals(new Object[]{1L, 2L, null, 3L}, (Object[])
actual.getRaw("dim"));
- Assert.assertEquals(Arrays.asList("1", "2", "null", "3"),
actual.getDimension("dim"));
+ Assert.assertArrayEquals(new String[]{"1", "2", null, "3"},
actual.getDimension("dim").toArray());
Review Comment:
assertEquals found it as other reference of ArrayList and failed with
assertion
```
java.lang.AssertionError: expected:
java.util.Arrays$ArrayList<[1.2000000476837158, 2.299999952316284, null,
3.4000000953674316]> but was: java.util.ArrayList<[1.2000000476837158,
2.299999952316284, null, 3.4000000953674316]>
Expected :java.util.Arrays$ArrayList<[1.2000000476837158, 2.299999952316284,
null, 3.4000000953674316]>
Actual :java.util.ArrayList<[1.2000000476837158, 2.299999952316284, null,
3.4000000953674316]>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
