kgyrtkirk commented on code in PR #15148:
URL: https://github.com/apache/druid/pull/15148#discussion_r1361726925
##########
extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/simple/ParquetGroupConverter.java:
##########
@@ -492,10 +510,12 @@ private static BigDecimal convertBinaryToDecimal(Binary
value, int precision, in
}
private final boolean binaryAsString;
+ private final boolean convertCorruptDates;
- public ParquetGroupConverter(boolean binaryAsString)
+ public ParquetGroupConverter(boolean binaryAsString, boolean
convertCorruptDates)
{
this.binaryAsString = binaryAsString;
Review Comment:
yes; it should be used around
[here](https://github.com/apache/druid/blob/c3bab1685db50d03809e33d249c47aad594ef043/extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/simple/ParquetGroupConverter.java#L436)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
