kgyrtkirk commented on code in PR #15148:
URL: https://github.com/apache/druid/pull/15148#discussion_r1361750791
##########
extensions-core/parquet-extensions/src/main/java/org/apache/druid/data/input/parquet/simple/ParquetGroupConverter.java:
##########
@@ -52,10 +52,14 @@ public class ParquetGroupConverter
private static final long NANOS_PER_MILLISECOND =
TimeUnit.MILLISECONDS.toNanos(1);
/**
- * See {@link ParquetGroupConverter#convertField(Group, String)}
+ * Convert a parquet group field as though it were a map. Logical types of
'list' and 'map' will be transformed
+ * into java lists and maps respectively ({@link
ParquetGroupConverter#convertLogicalList} and
+ * {@link ParquetGroupConverter#convertLogicalMap}), repeated fields will
also be translated to lists, and
+ * primitive types will be extracted into an ingestion friendly state (e.g.
'int' and 'long'). Finally,
+ * if a field is not present, this method will return null.
*/
@Nullable
- private static Object convertField(Group g, String fieldName, boolean
binaryAsString)
Review Comment:
`binaryAsString` was passed around in `private static` methods in a class on
which an `instance method` was called first....so I've choosen to remove them
(and use the implict class access - to get it where needed) ; instead of adding
another boolean to every static method
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
