kgyrtkirk commented on code in PR #15118:
URL: https://github.com/apache/druid/pull/15118#discussion_r1368356807
##########
sql/src/test/java/org/apache/druid/sql/calcite/QueryTestRunner.java:
##########
@@ -122,15 +123,15 @@ public static class QueryResults
public final List<Query<?>> recordedQueries;
public final Set<ResourceAction> resourceActions;
public final RuntimeException exception;
- public final PlannerCaptureHook capture;
+ public final PlannerHook capture;
public QueryResults(
final Map<String, Object> queryContext,
final String vectorizeOption,
final RelDataType sqlSignature,
final List<Object[]> results,
final List<Query<?>> recordedQueries,
- final PlannerCaptureHook capture
+ final PlannerHook capture
Review Comment:
I changed it to have the interface instead ; so that later other
implementations can be used
...however it can be interpreted like the `system captures` a set of things
for you and here they are in the `QueryResults`
I would rather see the results of this hook like a map of values or
something instead of the hook itself...
I find this whole thing oddly designed as the interface has only `captureX`
methods ; meanwhile the `PlannerCaptureHook` has the `getX`-s
should I change it back?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
