kgyrtkirk commented on code in PR #15118:
URL: https://github.com/apache/druid/pull/15118#discussion_r1368705945
##########
sql/src/test/java/org/apache/druid/sql/calcite/DrillWindowQueryTest.java:
##########
@@ -377,12 +381,10 @@ public void verify(String sql, QueryResults queryResults)
}
}
- private boolean isOrdered(String sql)
+ private boolean isOrdered(QueryResults queryResults)
{
- // FIXME: SqlToRelConverter.isOrdered(null) would be better
- sql = sql.toLowerCase(Locale.ENGLISH).replace('\n', ' ');
- sql = sql.substring(sql.lastIndexOf(')'));
- return sql.contains("order");
+ SqlNode sqlNode = ((PlannerCaptureHook)
queryResults.capture).getSqlNode();
Review Comment:
sure; I think my IDE will remove this cast right away when I next change
that file
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
