rohangarg commented on code in PR #15118:
URL: https://github.com/apache/druid/pull/15118#discussion_r1368367100
##########
sql/src/test/java/org/apache/druid/sql/calcite/QueryTestRunner.java:
##########
@@ -122,15 +123,15 @@ public static class QueryResults
public final List<Query<?>> recordedQueries;
public final Set<ResourceAction> resourceActions;
public final RuntimeException exception;
- public final PlannerCaptureHook capture;
+ public final PlannerHook capture;
public QueryResults(
final Map<String, Object> queryContext,
final String vectorizeOption,
final RelDataType sqlSignature,
final List<Object[]> results,
final List<Query<?>> recordedQueries,
- final PlannerCaptureHook capture
+ final PlannerHook capture
Review Comment:
Yes, I agree that the interface is a bit odd in terms of using it
practically. But given that we specifically know how we want to use it in the
tests, I think we can use `PlannerCaptureHook` itself - since that provides the
interface + extra capabilities/bridge methods that we need.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
