soumyava commented on code in PR #15222:
URL: https://github.com/apache/druid/pull/15222#discussion_r1374834656
##########
processing/src/test/java/org/apache/druid/segment/join/PostJoinCursorTest.java:
##########
@@ -0,0 +1,230 @@
+package org.apache.druid.segment.join;
+
+import com.google.common.collect.ImmutableList;
+import com.google.common.collect.Iterables;
+import org.apache.druid.java.util.common.Intervals;
+import org.apache.druid.java.util.common.granularity.Granularities;
+import org.apache.druid.java.util.common.granularity.Granularity;
+import org.apache.druid.java.util.common.guava.Sequence;
+import org.apache.druid.query.QueryInterruptedException;
+import org.apache.druid.query.QueryMetrics;
+import org.apache.druid.query.filter.Filter;
+import org.apache.druid.query.filter.ValueMatcher;
+import org.apache.druid.query.monomorphicprocessing.RuntimeShapeInspector;
+import org.apache.druid.segment.ColumnSelectorFactory;
+import org.apache.druid.segment.Cursor;
+import org.apache.druid.segment.QueryableIndex;
+import org.apache.druid.segment.QueryableIndexSegment;
+import org.apache.druid.segment.QueryableIndexStorageAdapter;
+import org.apache.druid.segment.StorageAdapter;
+import org.apache.druid.segment.VirtualColumns;
+import org.apache.druid.segment.join.filter.JoinFilterPreAnalysis;
+import org.apache.druid.timeline.SegmentId;
+import org.joda.time.DateTime;
+import org.joda.time.Interval;
+import org.junit.Test;
+
+import javax.annotation.Nullable;
+import java.io.IOException;
+import java.util.List;
+
+import static java.lang.Thread.sleep;
+import static org.junit.Assert.assertTrue;
+
+public class PostJoinCursorTest extends BaseHashJoinSegmentStorageAdapterTest
+{
+
+ public QueryableIndexSegment factSegment;
+
+ @Override
+ public void setUp() throws IOException
+ {
+
+ factSegment = new TestInfiniteQueryableIndexSegment(
+
JoinTestHelper.createFactIndexBuilder(temporaryFolder.newFolder()).buildMMappedIndex(),
+ SegmentId.dummy("facts")
+ );
+ countryIsoCodeToNameLookup =
JoinTestHelper.createCountryIsoCodeToNameLookup();
+ countryNumberToNameLookup =
JoinTestHelper.createCountryNumberToNameLookup();
+ countriesTable = JoinTestHelper.createCountriesIndexedTable();
+ regionsTable = JoinTestHelper.createRegionsIndexedTable();
+ }
+
+ /**
+ * Simulates infinite segment by using a base cursor with advance() and
advanceInterruptibly()
+ * reduced to a no-op.
+ */
+ private static class TestInfiniteQueryableIndexSegment extends
QueryableIndexSegment
+ {
+
+ private final StorageAdapter testStorageAdaptor;
+
+ public TestInfiniteQueryableIndexSegment(QueryableIndex index, SegmentId
segmentId)
+ {
+ super(index, segmentId);
+ testStorageAdaptor = new InfiniteQueryableIndexStorageAdapter(index);
+ }
+
+ @Override
+ public StorageAdapter asStorageAdapter()
+ {
+ return testStorageAdaptor;
+ }
+ }
+
+ private static class InfiniteQueryableIndexStorageAdapter extends
QueryableIndexStorageAdapter
+ {
+ public InfiniteQueryableIndexStorageAdapter(QueryableIndex index)
+ {
+ super(index);
+ }
+
+ @Override
+ public Sequence<Cursor> makeCursors(
+ @Nullable Filter filter,
+ Interval interval,
+ VirtualColumns virtualColumns,
+ Granularity gran,
+ boolean descending,
+ @Nullable QueryMetrics<?> queryMetrics
+ )
+ {
+ return super.makeCursors(filter, interval, virtualColumns, gran,
descending, queryMetrics).map(
+ CursorNoAdvance::new);
+ }
+
+ private static class CursorNoAdvance implements Cursor
+ {
+ Cursor cursor;
+
+ public CursorNoAdvance(Cursor cursor)
+ {
+ this.cursor = cursor;
+ }
+
+ @Override
+ public ColumnSelectorFactory getColumnSelectorFactory()
+ {
+ return cursor.getColumnSelectorFactory();
+ }
+
+ @Override
+ public DateTime getTime()
+ {
+ return cursor.getTime();
+ }
+
+ @Override
+ public void advance()
+ {
+ // Do nothing to simulate infinite rows
+ }
+
+ @Override
+ public void advanceUninterruptibly()
+ {
+ // Do nothing to simulate infinite rows
+ }
+
+ @Override
+ public boolean isDone()
+ {
+ return cursor.isDone();
+ }
+
+ @Override
+ public boolean isDoneOrInterrupted()
+ {
+ return cursor.isDoneOrInterrupted();
+ }
+
+ @Override
+ public void reset()
+ {
+
+ }
+ }
+ }
+
+ private static class ExceptionHandler implements
Thread.UncaughtExceptionHandler
+ {
+
+ Throwable exception;
+
+ @Override
+ public void uncaughtException(Thread t, Throwable e)
+ {
+ exception = e;
+ }
+
+ public Throwable getException()
+ {
+ return exception;
+ }
+ }
+
+ @Test
+ public void testAdvanceWithInterruption()
+ {
+ Thread joinCursorThread = new Thread(() -> makeCursorAndAdvance());
+ ExceptionHandler exceptionHandler = new ExceptionHandler();
+ joinCursorThread.setUncaughtExceptionHandler(exceptionHandler);
+ joinCursorThread.start();
+ try {
+ sleep(5000);
+ joinCursorThread.interrupt();
+ sleep(5000);
+ }
+ catch (InterruptedException e) {
+ throw new RuntimeException(e);
+ }
+
+ assertTrue(exceptionHandler.getException() instanceof
QueryInterruptedException);
+ }
+
+ public void makeCursorAndAdvance()
+ {
+
+ List<JoinableClause> joinableClauses = ImmutableList.of(
+ factToCountryOnIsoCode(JoinType.LEFT)
+ );
+
+ JoinFilterPreAnalysis joinFilterPreAnalysis = makeDefaultConfigPreAnalysis(
+ null,
+ joinableClauses,
+ VirtualColumns.EMPTY
+ );
+
+ HashJoinSegmentStorageAdapter hashJoinSegmentStorageAdapter = new
HashJoinSegmentStorageAdapter(
+ factSegment.asStorageAdapter(),
+ joinableClauses,
+ joinFilterPreAnalysis
+ );
+
+ Cursor cursor =
Iterables.getOnlyElement(hashJoinSegmentStorageAdapter.makeCursors(
+ null,
+ Intervals.ETERNITY,
+ VirtualColumns.EMPTY,
+ Granularities.ALL,
+ false,
+ null
+ ).toList());
+
+ ((PostJoinCursor)cursor).setValueMatcher(new ValueMatcher()
+ {
+ @Override
+ public boolean matches(boolean includeUnknown)
+ {
+ return false;
+ }
+
+ @Override
+ public void inspectRuntimeShape(RuntimeShapeInspector inspector)
+ {
+
+ }
+ });
+
+ cursor.advance();
+ }
+}
Review Comment:
Yeah it is needed, the checkstyle is complaining. It is good to run a `mvn
checkstyle:checkstyle` beforehand as Laksh have suggested earlier. Another
thing I do is in IntelliJ when adding a new section of code have the [druid
coding
style](https://raw.githubusercontent.com/apache/incubator-druid/master/dev/druid_intellij_formatting.xml)
and run a reformat code that fixes most of the codestyling for me
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
