gargvishesh commented on code in PR #15222:
URL: https://github.com/apache/druid/pull/15222#discussion_r1372916576
##########
processing/src/main/java/org/apache/druid/segment/join/PostJoinCursor.java:
##########
@@ -70,6 +70,15 @@ public static PostJoinCursor wrap(
}
private void advanceToMatch()
+ {
+ if (valueMatcher != null) {
+ while (!isDone() && !valueMatcher.matches(false)) {
+ baseCursor.advance();
+ }
+ }
+ }
+
+ private void advanceToMatchUninterruptibly()
Review Comment:
Done
##########
processing/src/main/java/org/apache/druid/segment/join/PostJoinCursor.java:
##########
@@ -99,15 +108,15 @@ public Filter getPostJoinFilter()
@Override
public void advance()
{
- advanceUninterruptibly();
- BaseQuery.checkInterrupted();
Review Comment:
Added a comment.
##########
processing/src/main/java/org/apache/druid/segment/join/PostJoinCursor.java:
##########
@@ -99,15 +108,15 @@ public Filter getPostJoinFilter()
@Override
public void advance()
{
- advanceUninterruptibly();
- BaseQuery.checkInterrupted();
+ baseCursor.advance();
Review Comment:
Added comments.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
