abhishekagarwal87 commented on code in PR #15222:
URL: https://github.com/apache/druid/pull/15222#discussion_r1368822377
##########
processing/src/main/java/org/apache/druid/segment/join/PostJoinCursor.java:
##########
@@ -70,6 +70,15 @@ public static PostJoinCursor wrap(
}
private void advanceToMatch()
+ {
+ if (valueMatcher != null) {
+ while (!isDone() && !valueMatcher.matches(false)) {
+ baseCursor.advance();
+ }
+ }
+ }
+
+ private void advanceToMatchUninterruptibly()
Review Comment:
Please leave a comment here that this can be a long-running CPU call. Which
is why advanceUninterruptibly is not directly used in advance() call unlike
other cursors. Please link the github issue in the comment.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
