AmatyaAvadhanula commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1382818853
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSequenceNumbers.java:
##########
@@ -61,4 +62,11 @@ SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> plus(
SeekableStreamSequenceNumbers<PartitionIdType, SequenceOffsetType> minus(
SeekableStreamSequenceNumbers<PartitionIdType, SequenceOffsetType> other
);
+
+ /**
+ * Compare this and the other sequence offsets using comparator.
+ * Returns 1, if this sequence is ahead of the other.
Review Comment:
Isn't it possible that when there are 10 partitions, 6 have strictly greater
sequence numbers while the remaining 4 have equal sequence numbers because no
new data was added to them?
I think we should retry in this case as well
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
