Pankaj260100 commented on code in PR #15141:
URL: https://github.com/apache/druid/pull/15141#discussion_r1383004203
##########
indexing-service/src/main/java/org/apache/druid/indexing/seekablestream/SeekableStreamSequenceNumbers.java:
##########
@@ -61,4 +62,11 @@ SeekableStreamSequenceNumbers<PartitionIdType,
SequenceOffsetType> plus(
SeekableStreamSequenceNumbers<PartitionIdType, SequenceOffsetType> minus(
SeekableStreamSequenceNumbers<PartitionIdType, SequenceOffsetType> other
);
+
+ /**
+ * Compare this and the other sequence offsets using comparator.
+ * Returns 1, if this sequence is ahead of the other.
Review Comment:
@AmatyaAvadhanula, This case is covered. We will retry when atleast one
partition sequence number is strictly greater than the other. We will compare
all partition offsets, and if we find one of the partition offsets greater than
the other offset, we update the res variable as true. And retry in that case.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
