georgew5656 opened a new pull request, #15372:
URL: https://github.com/apache/druid/pull/15372
### Description
Currently, AbstractTask.cleanup is run twice when running a small
index_parallel task with mmless ingestion because the
ParallelIndexSupervisorTask statically creates a IndexTask and call .run() on
it in its own .run() implementation.
Since both ParallelIndexSupervisorTask and IndexTask both subclass
AbstractTask, they both get .cleanup called in their .run implementation.
Because of this, task reports get uploaded twice (once by the IndexTask and
once by the ParallelIndexSupervisorTask). This is not technically a issue if
using S3 deep storage since ParallelIndexSupervisorTask gets its task status
from IndexTask and S3 just does a no-op overwrite of the report, but this seems
weird and practice and causes issues in Azure deep storage since it doesn't
support overwriting by default.
#### Fixed the bug ...
#### Renamed the class ...
#### Added a forbidden-apis entry ...
When creating the IndexTask, set shouldCleanup to false. Cleanup is handled
by the parent task.
#### Release note
Fix cleanup bug with index tasks and mmless ingestion.
##### Key changed/added classes in this PR
* `IndexTask`
* `ParallelIndexSupervisorTask`
This PR has:
- [X] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [X] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ X been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
