cryptoe commented on code in PR #15372:
URL: https://github.com/apache/druid/pull/15372#discussion_r1407622438
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java:
##########
@@ -2690,6 +2691,72 @@ public void testErrorWhenDropFlagTrueAndOverwriteFalse()
throws Exception
);
}
+ // If shouldCleanup is false, cleanup should be a no-op
+ @Test
+ public void testCleanupIndexTask() throws Exception
+ {
+ new IndexTask(
Review Comment:
Could you mention in a comment that since taskLockBox is empty, we would
throw a NPE if shouldCleanUp is true.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
