cryptoe commented on code in PR #15372:
URL: https://github.com/apache/druid/pull/15372#discussion_r1394167601
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/IndexTaskTest.java:
##########
@@ -2690,6 +2691,100 @@ public void
testErrorWhenDropFlagTrueAndOverwriteFalse() throws Exception
);
}
+ @Test
+ public void testDontCleanupIndexTask() throws Exception
+ {
+ new IndexTask(
+ null,
+ null,
+ null,
+ "dataSource",
+ null,
+ createDefaultIngestionSpec(
+ jsonMapper,
+ temporaryFolder.newFolder(),
+ new UniformGranularitySpec(
+ Granularities.MINUTE,
+ Granularities.MINUTE,
+
Collections.singletonList(Intervals.of("2014-01-01/2014-01-02"))
+ ),
+ null,
+ createTuningConfigWithMaxRowsPerSegment(10, true),
+ false,
+ false
+ ),
+ null,
+ 0,
+ false
+ ).cleanUp(null, null);
Review Comment:
What do these tests check ?
I would expect a EasyMock here where the IndexTask method cleanup is called
but AbtractBatchTaskMethod clean up is not called.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
