soumyava commented on code in PR #15302:
URL: https://github.com/apache/druid/pull/15302#discussion_r1393094768
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -723,7 +723,7 @@ public void
testFilterAndGroupByLookupUsingJoinOperatorBackwards(Map<String, Obj
),
"j0.",
equalsCondition(makeColumnExpression("k"),
makeColumnExpression("j0.dim2")),
- JoinType.RIGHT
+ JoinType.INNER
Review Comment:
Same comment as before, we are converting a right join to an inner join here
and that is changing the expected results
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
