abhishekagarwal87 commented on code in PR #15302:
URL: https://github.com/apache/druid/pull/15302#discussion_r1405425076
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -740,7 +740,6 @@ public void
testFilterAndGroupByLookupUsingJoinOperatorBackwards(Map<String, Obj
new Object[]{"xabc", 1L}
)
: ImmutableList.of(
- new Object[]{null, 5L},
Review Comment:
This result changed because there is a bug in splitting the join filter on
leaf nodes. A filter that can reject null cannot be pushed into the left table
if the join is right. But that's what
https://github.com/apache/druid/blob/master/processing/src/main/java/org/apache/druid/segment/join/filter/JoinFilterAnalyzer.java#L198
will do right now. I will fix this in another PR.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
