abhishekagarwal87 commented on code in PR #15302:
URL: https://github.com/apache/druid/pull/15302#discussion_r1405588289
##########
sql/src/test/java/org/apache/druid/sql/calcite/CalciteJoinQueryTest.java:
##########
@@ -768,7 +762,7 @@ public void
testFilterAndGroupByLookupUsingJoinOperatorWithNotFilter(Map<String,
new LookupDataSource("lookyloo"),
"j0.",
equalsCondition(makeColumnExpression("dim2"),
makeColumnExpression("j0.k")),
- JoinType.LEFT
+ JoinType.INNER
Review Comment:
There is a post-join filter that will reject nulls on the right side. Hence
the SQL query is equivalent to INNER join with post-join filter moved into the
join condition itself. That's also the same reason why some other join queries
have become INNER join queries. I have also now tweaked the rule a bit so that
we still reject non-equi conditions for non-sql compatible mode. With that,
results in non-sql compatible mode won't change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
