gianm commented on PR #15373: URL: https://github.com/apache/druid/pull/15373#issuecomment-1819625442
We had some discussion of this in Slack. In summary, #15260 fixes an NPE that occurs when a query comes in for a segment that has just been unloaded. This PR adds a delay between unannounce and unload, which reduces the likelihood that a query will come in for a segment that has just been unloaded. Both changes are good IMO— we want this case to be rare (which this patch helps with), but when it does happen it needs to be handled properly (which #15260 helps with). With this patch, the realtime tasks would behave more similarly to Historicals, which do already have a delay between unannouncing and unloading of 30 seconds (the `druid.segmentCache.dropSegmentDelayMillis`). -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
