kaisun2000 commented on PR #15373:
URL: https://github.com/apache/druid/pull/15373#issuecomment-1841540941
>@kaisun2000 - FWIW a peon can have segment loader config when it loads
broadcast segments. I think we can use the same property name since the purpose
is really just the same and we add the relevant documentation. Property name
aside, does it really need to be added to TaskConfig? can it be accessed
directly in same way as
druid.indexer.fork.property.druid.processing.numMergeBuffers is accessed?
@abhishekagarwal87, thanks for this further illustration.
Indeed, I see that `StorageNodeModule` is a base module that the `CliPeon`
would use via `Initialization:makeInjectorWithModules()`. Since
`StorageNodeModule` has the binding to `SegmentLoaderConfig`. We also have the
`druid.segmentCache.dropSegmentDelayMillis` in Peon, as you said.
In this case, shall we add a `SegmentLoaderConifg` to the
`TaskToolboxFactory` constructor?
```
@Inject
public TaskToolboxFactory(
SegmentLoaderConifg segmentLoadConfig, ---> added
TaskConfig config,
```
Then, later, when the `StreamAppenderator` is created, we can pass in the
`SegmentLoaderConfig` in its constructor?
Let me know if this sounds good? If so, I will make the change accordingly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
