kaisun2000 commented on PR #15373: URL: https://github.com/apache/druid/pull/15373#issuecomment-1851154904
Revised the PR , using `SegmentLoaderConfig.dropSegmentDelayMillis` to control segment drop delay in the realtime path similar to the historical segment drop path. The following are the overview of class changes: `TaskToolboxFactory` is injected with an instance of `SegmentLoaderConfig` 'TaskToolbox' built by `TaskToolboxFactory` would store a copy of `SegmentLoaderConfig`. In the appenderator creation path, changes are made accordingly so that the `StreamAppenderator` would have a copy of `SegmentLoaderConfig` from the 'TaskToolbox' The delay to drop logic is implemented in `StreamAppenderator`. @abhishekagarwal87, can we have another review to see if this approach reflects our discussion here? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
