AmatyaAvadhanula commented on code in PR #15590:
URL: https://github.com/apache/druid/pull/15590#discussion_r1429453811
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/actions/SegmentAllocationQueue.java:
##########
@@ -196,6 +204,7 @@ public Future<SegmentIdWithShardSpec>
add(SegmentAllocateRequest request)
}
});
+ scheduleQueuePoll(maxWaitTimeMillis);
Review Comment:
Should this be part of the method `addBatchToQueue` itself?
1. With the current code, I think it's possible that requeued batches may
not be processed if new requests don't come in.
2. I also don't think we need to schedule a poll for every new request, but
just for the first one for a batch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
