kfaraz commented on PR #15590: URL: https://github.com/apache/druid/pull/15590#issuecomment-1863804076
Thanks for the suggestion, @AmatyaAvadhanula . To help me understand better, would a more precise statement instead of `Requests with lineage check cannot be batched.` be that `Requests with lineage check are only sent to the overlord one by one as each subsequent request needs the previous segment id, so there is no scope of batching them.`? I ask this because the `SegmentAllocationQueue` code itself does not distinguish between lineage check or no lineage check. Either way, my plan is to eventually get rid of `batchAllocationWaitTime` altogether, so that no request needs to wait unless some other batch is already being processed. That would benefit all types of requests. The change in this PR is just to stabilize the code so that we can try out `batchAllocationWaitTime = 0` before removing the config or updating its default values. Please let me know what you think. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
