kfaraz commented on code in PR #15710:
URL: https://github.com/apache/druid/pull/15710#discussion_r1456927099
##########
server/src/main/java/org/apache/druid/indexing/overlord/IndexerMetadataStorageCoordinator.java:
##########
@@ -127,11 +128,23 @@ Collection<DataSegment> retrieveUsedSegmentsForIntervals(
);
/**
- * see {@link #retrieveUnusedSegmentsForInterval(String, Interval, Integer)}
+ * See {@link #retrieveUnusedSegmentsForInterval(String, Interval, Integer,
DateTime)}.
*/
default List<DataSegment> retrieveUnusedSegmentsForInterval(String
dataSource, Interval interval)
{
- return retrieveUnusedSegmentsForInterval(dataSource, interval, null);
+ return retrieveUnusedSegmentsForInterval(dataSource, interval, null, null);
+ }
+
+ /**
+ * See {@link #retrieveUnusedSegmentsForInterval(String, Interval, Integer,
DateTime)}.
+ */
+ default List<DataSegment> retrieveUnusedSegmentsForInterval(
Review Comment:
That makes sense, but this is internal interface used only within a single
service and not while communicating across services.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
