kfaraz commented on code in PR #15710:
URL: https://github.com/apache/druid/pull/15710#discussion_r1456927865
##########
server/src/main/java/org/apache/druid/rpc/indexing/OverlordClient.java:
##########
@@ -72,21 +73,28 @@ public interface OverlordClient
ListenableFuture<Void> runTask(String taskId, Object taskObject);
/**
- * Run a "kill" task for a particular datasource and interval. Shortcut to
{@link #runTask(String, Object)}.
- *
- * The kill task deletes all unused segment records from deep storage and
the metadata store. The task runs
- * asynchronously after the API call returns. The resolved future is the ID
of the task, which can be used to
- * monitor its progress through the {@link #taskStatus(String)} API.
- *
- * @param idPrefix Descriptive prefix to include at the start of task IDs
- * @param dataSource Datasource to kill
- * @param interval Interval to kill
- *
- * @return future with task ID
+ * Shortcut to {@link #runKillTask(String, String, Interval, Integer,
DateTime)}.
+ * Note that this method is deprecated and newer implementations must use
{@link #runKillTask(String, String, Interval, Integer, DateTime)}.
*/
+ @Deprecated
Review Comment:
Doesn't seem like this would have any rolling upgrade concerns as you have
just added a new nullable parameter that would be sent over the wire. A service
on an older version would just read that param as null.
##########
server/src/main/java/org/apache/druid/rpc/indexing/OverlordClient.java:
##########
@@ -72,21 +73,28 @@ public interface OverlordClient
ListenableFuture<Void> runTask(String taskId, Object taskObject);
/**
- * Run a "kill" task for a particular datasource and interval. Shortcut to
{@link #runTask(String, Object)}.
- *
- * The kill task deletes all unused segment records from deep storage and
the metadata store. The task runs
- * asynchronously after the API call returns. The resolved future is the ID
of the task, which can be used to
- * monitor its progress through the {@link #taskStatus(String)} API.
- *
- * @param idPrefix Descriptive prefix to include at the start of task IDs
- * @param dataSource Datasource to kill
- * @param interval Interval to kill
- *
- * @return future with task ID
+ * Shortcut to {@link #runKillTask(String, String, Interval, Integer,
DateTime)}.
+ * Note that this method is deprecated and newer implementations must use
{@link #runKillTask(String, String, Interval, Integer, DateTime)}.
*/
+ @Deprecated
Review Comment:
Yeah, doesn't seem like this would have any rolling upgrade concerns as you
have just added a new nullable parameter that would be sent over the wire. A
service on an older version would just read that param as null.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
