abhishekrb19 commented on code in PR #15710:
URL: https://github.com/apache/druid/pull/15710#discussion_r1457076886
##########
server/src/main/java/org/apache/druid/server/coordinator/duty/KillUnusedSegments.java:
##########
@@ -159,10 +176,9 @@ DruidCoordinatorRuntimeParams
runInternal(DruidCoordinatorRuntimeParams params)
dataSourcesToKill =
segmentsMetadataManager.retrieveAllDataSourceNames();
}
- log.debug("Killing unused segments in datasources: %s",
dataSourcesToKill);
- lastKillTime = System.currentTimeMillis();
+ log.debug("Killing unused segments for datasources[%s]",
dataSourcesToKill);
+ lastKillTime = DateTimes.nowUtc();
Review Comment:
Yeah, I think this makes sense. Would defer making this behavioral change in
a follow-up to avoid mixing up too many unrelated changes in this patch
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
