abhishekagarwal87 commented on code in PR #15754:
URL: https://github.com/apache/druid/pull/15754#discussion_r1478079564
##########
processing/src/main/java/org/apache/druid/query/QueryRunner.java:
##########
@@ -31,7 +31,7 @@ public interface QueryRunner<T>
* Runs the given query and returns results in a time-ordered sequence.
*/
Sequence<T> run(QueryPlus<T> queryPlus, ResponseContext responseContext);
-
+
Review Comment:
could revert this change completely.
##########
server/src/main/java/org/apache/druid/client/DirectDruidClient.java:
##########
@@ -551,7 +553,7 @@ private void cancelQuery(Query<T> query, String cancelUrl)
if (!responseFuture.isDone()) {
log.error("Error cancelling query[%s]", query);
}
- StatusResponseHolder response = responseFuture.get();
+ StatusResponseHolder response = responseFuture.get(5,
TimeUnit.SECONDS);
Review Comment:
Should we set it to 30? I don't have a strong opinion but 5 seems low.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
