BartMiki commented on PR #15754: URL: https://github.com/apache/druid/pull/15754#issuecomment-1926620742
@abhishekagarwal87 Hi! I see that some tests failed, so I checked if there is already a code change in the master that fixes these tests. I did not change the classes that work with these tests. However, when I check out the current master, these tests also don't work. It is easy to fix them, but I wonder if I should too that in this PR? It is this [test](https://github.com/apache/druid/blob/959148ad370f4133c59f24f8afc3f297b0911e41/server/src/test/java/org/apache/druid/discovery/BrokerClientTest.java#L104). It doesn't work, because the server sends 504 [here](https://github.com/apache/druid/blob/959148ad370f4133c59f24f8afc3f297b0911e41/server/src/test/java/org/apache/druid/discovery/BrokerClientTest.java#L150) and the [sendQuery](https://github.com/apache/druid/blob/96be82a3e67bb3fdb62d0640c0c8885f7f5813b0/server/src/main/java/org/apache/druid/discovery/BrokerClient.java#L78) fails using retry utils, because it returns `DruidException` which is `RuntimeException`, but recovery is only supported for `IOE` or `ExecutionException` (if cause is `IOException` or `ChannelException`) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
