LakshSingla commented on code in PR #15700: URL: https://github.com/apache/druid/pull/15700#discussion_r1479322910
########## processing/src/main/java/org/apache/druid/query/aggregation/SingleValueBufferAggregator.java: ########## @@ -0,0 +1,129 @@ +/* + * Licensed to the Apache Software Foundation (ASF) under one + * or more contributor license agreements. See the NOTICE file + * distributed with this work for additional information + * regarding copyright ownership. The ASF licenses this file + * to you under the Apache License, Version 2.0 (the + * "License"); you may not use this file except in compliance + * with the License. You may obtain a copy of the License at + * + * http://www.apache.org/licenses/LICENSE-2.0 + * + * Unless required by applicable law or agreed to in writing, + * software distributed under the License is distributed on an + * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + * KIND, either express or implied. See the License for the + * specific language governing permissions and limitations + * under the License. + */ + +package org.apache.druid.query.aggregation; + +import org.apache.druid.common.config.NullHandling; +import org.apache.druid.error.DruidException; +import org.apache.druid.error.InvalidInput; +import org.apache.druid.java.util.common.ISE; +import org.apache.druid.segment.ColumnValueSelector; +import org.apache.druid.segment.column.ColumnType; +import org.apache.druid.segment.column.NullableTypeStrategy; +import org.apache.druid.segment.column.TypeStrategies; + +import javax.annotation.Nullable; +import java.nio.ByteBuffer; + +public class SingleValueBufferAggregator implements BufferAggregator +{ + final ColumnValueSelector selector; + final ColumnType columnType; + final NullableTypeStrategy typeStrategy; + private boolean isAggregateInvoked = false; + + SingleValueBufferAggregator(ColumnValueSelector selector, ColumnType columnType) + { + this.selector = selector; + this.columnType = columnType; + this.typeStrategy = columnType.getNullableStrategy(); + } + + @Override + public void init(ByteBuffer buf, int position) + { + buf.put(position, NullHandling.IS_NULL_BYTE); + } + + @Override + public void aggregate(ByteBuffer buf, int position) + { + if (isAggregateInvoked) { + throw InvalidInput.exception("Subquery expression returned more than one row"); + } + + int written = typeStrategy.write( + buf, + position, + getSelectorObject(), + columnType.isNumeric() ? Double.BYTES + Byte.BYTES : SingleValueAggregatorFactory.DEFAULT_MAX_BUFFER_SIZE + ); + if (written < 0) { + throw DruidException.forPersona(DruidException.Persona.ADMIN) + .ofCategory(DruidException.Category.RUNTIME_FAILURE) + .build("Single Value Aggregator value exceeds buffer limit"); Review Comment: Error message isn't denoting what happens. This should also be along the lines of "subquery's result value exceeds buffer limit [%s]", BUFFER_LIMIT". Also, the error should mention the buffer size, so that the user knows what might be going on. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
