AmatyaAvadhanula opened a new pull request, #15952:
URL: https://github.com/apache/druid/pull/15952
The coordinator tries to poll segments every minute (or based on the
configured periodicPollDelay)
In each cycle, the DataSourcesSnapshot
1) Polls the database for all used segments
2) Create a segment timeline for each of the datasources
3) Determine all the overshadowed segments
The third step to compute overshadowed segments is currently based on
calling `isOvershadowed` on each segment individually. The complexity for this
operation is O(n ^ 2) for each interval with n segments.
This can lead to coordinator polls happening infrequently, which causes a
delay in segments being discovered after having been committed, which leads to
stale data and slow handoffs etc.
This PR tries to add a configuration and later deduplicate these calls with
the existing `findFullyOvershadowed` method.
TODO:
- Add tests to ensure correctness of the new method
- Add proper benchmarks
This PR has:
- [ ] been self-reviewed.
- [ ] using the [concurrency
checklist](https://github.com/apache/druid/blob/master/dev/code-review/concurrency.md)
(Remove this item if the PR doesn't have any relation to concurrency.)
- [ ] added documentation for new or modified features or behaviors.
- [ ] a release note entry in the PR description.
- [ ] added Javadocs for most classes and all non-trivial methods. Linked
related entities via Javadoc links.
- [ ] added or updated version, license, or notice information in
[licenses.yaml](https://github.com/apache/druid/blob/master/dev/license.md)
- [ ] added comments explaining the "why" and the intent of the code
wherever would not be obvious for an unfamiliar reader.
- [ ] added unit tests or modified existing tests to cover new code paths,
ensuring the threshold for [code
coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md)
is met.
- [ ] added integration tests.
- [ ] been tested in a test Druid cluster.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
