AmatyaAvadhanula commented on code in PR #15952:
URL: https://github.com/apache/druid/pull/15952#discussion_r1508540758
##########
server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java:
##########
@@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig
@JsonProperty
private Period pollDuration = new Period("PT1M");
+ @JsonProperty
+ private boolean useFindFullyOvershadowed;
Review Comment:
Yes, it is.
I think there may be a flaw in the current method though. (It assumes that
the interval is immutable)
Perhaps we could just maintain the maxValue in the holder for an interval
which is updated whenever new segments are added.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]