kfaraz commented on code in PR #15952:
URL: https://github.com/apache/druid/pull/15952#discussion_r1501739725
##########
server/src/main/java/org/apache/druid/metadata/SegmentsMetadataManagerConfig.java:
##########
@@ -31,6 +31,9 @@ public class SegmentsMetadataManagerConfig
@JsonProperty
private Period pollDuration = new Period("PT1M");
+ @JsonProperty
+ private boolean useFindFullyOvershadowed;
Review Comment:
We shouldn't need a config to choose a better code path. If the new flow is
better, it should be used in all cases.
If we need some config to avoid using the new flow in cases where segment
locking has been used, then the config should disable segment locking itself
and throw an exception if someone tries to use segment locking. Only then can
we be sure that the coordinator is operating safely.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
