clintropolis opened a new pull request, #15963: URL: https://github.com/apache/druid/pull/15963
### Description Fixes `regexp_like`, `contains_string`, and `icontains_string` to return `null` instead of `false` in SQL compatible null handling mode to have correct three-value logic behavior. I did not put this behavior behind a flag, though if we are worried about the bug fix changing behavior I suppose we could associate it with `NullHandling.useThreeValueLogic()`, though kind of weird since that is currently tied to use for native filters, or `ExpressionProcessing.useStrictBooleans()` which traditionally controls the other expression related 3vl stuff. #### Release note `REGEXP_LIKE`, `CONTAINS_STRING`, and `ICONTAINS_STRING` correctly return null for null value inputs in SQL compatible null handling mode (the default configuration). <hr> This PR has: - [x] been self-reviewed. - [x] a release note entry in the PR description. - [x] added comments explaining the "why" and the intent of the code wherever would not be obvious for an unfamiliar reader. - [x] added unit tests or modified existing tests to cover new code paths, ensuring the threshold for [code coverage](https://github.com/apache/druid/blob/master/dev/code-review/code-coverage.md) is met. - [x] been tested in a test Druid cluster. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
