clintropolis commented on PR #15963: URL: https://github.com/apache/druid/pull/15963#issuecomment-1965396106
> let's put it behind one of these feature flags, please :) My experience is that long-time users often adjust to this weird behavior and then complain about their workflows breaking. The problem is that neither of these feature flags seem very appropriate. `druid.generic.useThreeValueLogicForNativeFilters` definitely seems not right because it has 'native filters' in the name. `druid.expressions.useStrictBooleans` also doesn't really feel right because the primary thing that config does is make 'LONG' be the standard boolean type, instead of a mix of boolean-ish types. It by side-effect has some three-value logic stuff that it fixed with AND and OR filters, but doesn't fully control SQL compatible three-value logic behavior for the rest of expressions, for the most part, that just happens by default if `druid.generic.useDefaultValueForNull=false`. I'm pretty strongly opposed to adding yet _another_ feature flag for a bug fix, it isn't really sustainable. This fix already only has any effect if `druid.generic.useDefaultValueForNull=false`... -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
