abhishekrb19 commented on code in PR #15994:
URL: https://github.com/apache/druid/pull/15994#discussion_r1505579554
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/KillUnusedSegmentsTask.java:
##########
@@ -131,8 +137,12 @@ public KillUnusedSegmentsTask(
if (limit != null && Boolean.TRUE.equals(markAsUnused)) {
throw InvalidInput.exception("limit[%d] cannot be provided when
markAsUnused is enabled.", limit);
}
+ if (version != null && Boolean.TRUE.equals(markAsUnused)) {
+ throw InvalidInput.exception("version[%s] cannot be provided when
markAsUnused is enabled.", version);
Review Comment:
I didn't change the mark used/unused APIs to support version in this patch
to keep the changes easy to review. Also, the `markAsUnused` option is
deprecated, so maybe it's ok to keep it this way?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
