georgew5656 commented on code in PR #15981:
URL: https://github.com/apache/druid/pull/15981#discussion_r1507739056
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -821,10 +836,10 @@ TaskStatus runHashPartitionMultiPhaseParallel(TaskToolbox
toolbox) throws Except
taskStatus = TaskStatus.failure(getId(), errMsg);
}
- toolbox.getTaskReportFileWriter().write(
- getId(),
- getTaskCompletionReports(taskStatus,
segmentAvailabilityConfirmationCompleted)
- );
+ completionReports = getTaskCompletionReports(taskStatus,
segmentAvailabilityConfirmationCompleted);
+ if (!ingestionSchema.isSkipPublishingReports()) {
+ toolbox.getTaskReportFileWriter().write(getId(), completionReports);
Review Comment:
wondering if we actually need to do this, wouldn't the CompactionTask logic
overwrite the file with the correct data anyways?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
