georgew5656 commented on code in PR #15981:
URL: https://github.com/apache/druid/pull/15981#discussion_r1507752572
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -292,6 +293,20 @@ public Set<ResourceAction> getInputSourceResources()
ImmutableSet.of();
}
+ @Nullable
Review Comment:
imo it makes more sense to have skipPublishingReports be on the
ParallelIndexSupervisorTask rather than the ParallelIndexIngestionSpec. the
spec is user facing and i don't think we would ever want this field to be user
settable
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
