adithyachakilam commented on code in PR #15981:
URL: https://github.com/apache/druid/pull/15981#discussion_r1507834156


##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/CompactionTask.java:
##########
@@ -514,6 +518,9 @@ public TaskStatus runTask(TaskToolbox toolbox) throws 
Exception
               failCnt++;
               log.warn("Failed to run indexSpec: [%s].\nTrying the next 
indexSpec.", json);
             }
+            Optional.ofNullable(eachSpec.getCompletionReports())
+                    .ifPresent(reports -> completionReports.putAll(
+                        CollectionUtils.mapKeys(reports, key -> 
getReportkey(eachSpec.getBaseSubtaskSpecName(), key))));

Review Comment:
   `getBaseSubtaskSpecName` already includes the `0` and `1`s. i was trying to 
use the same indexes here rather than generate them again (bcoz anything throws 
exception in middle we would deviate from the actual index.)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to