gianm commented on code in PR #15920: URL: https://github.com/apache/druid/pull/15920#discussion_r1509438115
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java: ########## @@ -152,6 +154,7 @@ public class MultiStageQueryContext public static final String CTX_ARRAY_INGEST_MODE = "arrayIngestMode"; public static final ArrayIngestMode DEFAULT_ARRAY_INGEST_MODE = ArrayIngestMode.MVD; + public static final String CTX_SKIP_TYPE_VERIFICATION = "skipTypeVerification"; Review Comment: I don't think `ARRAY_TO_MV` and `MV_TO_ARRAY` would be helpful, since the purpose of this parameter is to allow someone to explicitly decide to ingest mismatched types. Whereas, `ARRAY_TO_MV` and `MV_TO_ARRAY` are more something that users could use to make types line up properly. I'm not sure why anyone would want to bypass this validation and ingest mismatched types, to be honest. But I added this since I felt weird about having a type validation with no way to bypass it. I do agree it's not really ideal for it to be a new context parameter. I just couldn't think of another approach to allowing validation bypass for specific columns, without a table-level catalog. I wonder if you have any thoughts here? (or anyone else?) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
