clintropolis commented on code in PR #15920: URL: https://github.com/apache/druid/pull/15920#discussion_r1509471963
########## extensions-core/multi-stage-query/src/main/java/org/apache/druid/msq/util/MultiStageQueryContext.java: ########## @@ -152,6 +154,7 @@ public class MultiStageQueryContext public static final String CTX_ARRAY_INGEST_MODE = "arrayIngestMode"; public static final ArrayIngestMode DEFAULT_ARRAY_INGEST_MODE = ArrayIngestMode.MVD; + public static final String CTX_SKIP_TYPE_VERIFICATION = "skipTypeVerification"; Review Comment: the context flag seems ok to me, especially since i don't think we're quite yet in a place where a lot of people will want to be using a mix of mvds and arrays, we are missing optimized versions of `MV_TO_ARRAY` and `ARRAY_TO_MV` to make things a lot more efficient to use a mix of stuff. I feel like once we've transitioned to `array` being default `arrayIngestMode`, given some time for it to settle, and then eventually remove `arrayIngestMode` to drop all of the other behaviors, we might be able to consider removing this validation in favor of pushing it to the catalog since the old habits would be gone and at that point it should also be a lot less painful to work with a mix of stuff. But we can revisit once `arrayIngestMode` is removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
