kfaraz commented on code in PR #16042:
URL: https://github.com/apache/druid/pull/16042#discussion_r1513015091
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -226,7 +226,8 @@ public IndexTask(
IndexIngestionSpec ingestionSchema,
Map<String, Object> context,
int maxAllowedLockCount,
- boolean isStandAloneTask
+ boolean shouldCleanup,
+ boolean shouldSendReports
Review Comment:
Javadoc for these arguments would be helpful.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -1261,8 +1252,13 @@ private Map<String, TaskReport>
getTaskCompletionReports(TaskStatus taskStatus,
);
}
- private void writeCompletionReports(TaskToolbox toolbox)
+ private void updateAndWriteCompletionReports(
+ TaskToolbox toolbox,
+ TaskStatus status,
+ boolean segmentAvailabilityConfirmationCompleted
Review Comment:
This is a member field of this class and need not be passed as an argument.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/batch/parallel/ParallelIndexSupervisorTask.java:
##########
@@ -203,7 +203,7 @@ public class ParallelIndexSupervisorTask extends
AbstractBatchIndexTask implemen
private IngestionState ingestionState;
private Map<String, TaskReport> completionReports;
- private final Boolean isCompactionTask;
+ private final boolean isCompactionTask;
Review Comment:
The corresponding argument in the constructor should be changed too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
