georgew5656 commented on PR #16042:
URL: https://github.com/apache/druid/pull/16042#issuecomment-1979380105
> is this actually the behavior we want? it seems to contradict the behavior
of other situations where we run a task inside another task where we expect the
parent task to write its own reports
looking at the code it seems to me all the other branches in
ParallelIndexSupervisorTask call writeCompletionReports using the task report
of the subtask generated (runRangePartitionMultiPhaseParallel,
runSinglePhaseParallel, runHashPartitionMultiPhaseParallel)
I see there's already this code
```
if (currentSubTaskHolder.setTask(sequentialIndexTask)
&& sequentialIndexTask.isReady(toolbox.getTaskActionClient())) {
TaskStatus status = sequentialIndexTask.run(toolbox);
completionReports = sequentialIndexTask.getCompletionReports();
return status;
} else {
String msg = "Task was asked to stop. Finish as failed";
LOG.info(msg);
return TaskStatus.failure(getId(), msg);
}
```
shouldn't we just call writeCompletionReports here instead?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
