kfaraz commented on code in PR #16042:
URL: https://github.com/apache/druid/pull/16042#discussion_r1513736815
##########
indexing-service/src/test/java/org/apache/druid/indexing/common/task/TaskReportSerdeTest.java:
##########
@@ -94,6 +94,52 @@ public void testSerde() throws Exception
Assert.assertEquals(reportMap1, reportMap2);
}
+ @Test
+ public void testSerializationOnMissingPartitionStats() throws Exception
Review Comment:
Thanks for adding the test.
##########
indexing-service/src/main/java/org/apache/druid/indexing/common/task/IndexTask.java:
##########
@@ -217,6 +215,11 @@ public IndexTask(
);
}
+ /**
+ * @param isStandAloneTask used to specify if indextask.run() is run as a
part of another task
+ * skips writing reports and cleanup if not a
standalone task
+ */
+
Review Comment:
Nit: extra line?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
