georgew5656 commented on code in PR #16020:
URL: https://github.com/apache/druid/pull/16020#discussion_r1513497839
##########
server/src/main/java/org/apache/druid/server/coordinator/DruidCoordinator.java:
##########
@@ -242,7 +242,7 @@ public Object2IntMap<String>
getDatasourceToUnavailableSegmentCount()
final Iterable<DataSegment> dataSegments =
metadataManager.segments().iterateAllUsedSegments();
for (DataSegment segment : dataSegments) {
SegmentReplicaCount replicaCount =
segmentReplicationStatus.getReplicaCountsInCluster(segment.getId());
- if (replicaCount != null && replicaCount.totalLoaded() > 0) {
+ if (replicaCount != null && (replicaCount.totalLoaded() > 0 ||
replicaCount.required() == 0)) {
Review Comment:
i don't think this is changing the existing behavior afaik. before this
change, if a segment was not loaded via a load rule it would not be included in
segment/unavailable/count, now the behavior would be the same.
the difference would be that a segment that is not loaded onto a historical
(hot rule) but is covered by a cold rule is no longer counted in
segment/unavailable/count.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
