georgew5656 commented on PR #16020: URL: https://github.com/apache/druid/pull/16020#issuecomment-1973790784
> Very nice! 👍 > > Given that the test has a 60s timeout - could we add these changes to one of the existing tests to test this instead of adding a new test and extending the dead time that the unit tests have to run for? Maybe in `#testCoordinatorTieredRun`? is that timeout a maximum or a static config? when i ran it locally the test went pretty fast, like 5 seconds. i did consider moving it into one of the existing test but I thought what I was testing was different enough that it deserved its own test (no segment assignment to historicals, etc) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
